Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix discard stats moved by GC bug #929

Merged
merged 9 commits into from
Jul 18, 2019
Merged

Fix discard stats moved by GC bug #929

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
804d65b
Fix discard stats moved by GC bug
Jul 13, 2019
5c521f4
Fix empty value log
Jul 13, 2019
16acdfe
Return nil instead of breaking the for loop
Jul 13, 2019
0265e38
Fix return/break
Jul 13, 2019
1f820c3
Move test from db_test.go to value_test.go
Jul 13, 2019
30303cf
Add comments
Jul 13, 2019
23079fa
Clean up code
Jul 17, 2019
0409841
Merge branch 'master' into ibrahim/discardstats-gc
Jul 18, 2019
e8facf6
fixup
Jul 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix empty value log
  • Loading branch information
Ibrahim Jarif committed Jul 13, 2019
commit 5c521f4795bbbbd7144efd91ecb4c01c0e5c9a07
6 changes: 3 additions & 3 deletions value.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1438,10 +1438,10 @@ func (vlog *valueLog) populateDiscardStats() error {
if err != nil {
return err
}
// Vlaue doesn't exist.
// Value doesn't exist.
if vs.Meta == 0 && len(vs.Value) == 0 {
vs.Value = []byte{}
break
vlog.opt.Debugf("Value log discard stats empty")
return nil
}
vp.Decode(vs.Value)
// Entry stored in LSM tree.
Expand Down