Do not return error from builder.Add method #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 1, 2019 19:16
The builder.Add method doesn't need to return an error. We always return nil and it has to be handled everywhere. This commit removes it.
jarifibrahim
requested review from
ashish-goswami,
manishrjain and
a team
as code owners
manishrjain
approved these changes
Aug 1, 2019
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ashish-goswami)
ashish-goswami
approved these changes
Aug 2, 2019
There was a problem hiding this comment.
Reviewable status:
jarifibrahim
pushed a commit
that referenced
this pull request
Aug 9, 2019
The builder.Add method doesn't need to return an error. We always return nil and it has to be handled everywhere. This commit removes it.
jarifibrahim
pushed a commit
that referenced
this pull request
Mar 12, 2020
The builder.Add method doesn't need to return an error. We always return nil and it has to be handled everywhere. This commit removes it. (cherry picked from commit e627d49)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The builder.Add method doesn't need to return an error. We always return
nil and it has to be handled everywhere. This commit removes it.
This change is