Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/v1.2 - fix(task): Return error on closed DB (#6075) #6319

Merged
merged 2 commits into from
Aug 31, 2020

Commits on Aug 29, 2020

  1. fix(task): Return error on closed DB (#6075)

    Fixes DGRAPH-2181
    
    The queries in dgraph are processed in separate goroutines. The pstore badger DB
    could be closed while the query was being processed. This causes panics such as
    ```
    panic: runtime error: invalid memory address or nil pointer dereference
    	panic: Unclosed iterator at time of Txn.Discard.
    [signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x11d2311]
    
    goroutine 19298 [running]:
    github.com/dgraph-io/badger/v2.(*Txn).Discard(0xc05586bc20)
    	/go/pkg/mod/github.com/dgraph-io/badger/v2@v2.0.1-rc1.0.20200718033852-37ee16d8ad1c/txn.go:517 +0xc1
    panic(0x19e26a0, 0x2988560)
    	/usr/local/go/src/runtime/panic.go:969 +0x166
    github.com/dgraph-io/badger/v2/skl.(*Skiplist).IncrRef(...)
    ```
    This PR attempts to reduce the number of such crashes. This PR doesn't fix the actual
    issue but it tries to reduce the probability of such crashes by checking if badger is not
    closed before accessing it.
    
    An ideal fix would be to stop all the goroutines started by dgraph while closing DB so
    that we don't try to read from a closed badger DB.
    
    (cherry picked from commit 3cea0fe)
    Ibrahim Jarif committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    38ac76a View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2020

  1. Merge branch 'release/v1.2' into ibrahim/r1.2-isclosed

    Ibrahim Jarif authored Aug 31, 2020
    Configuration menu
    Copy the full SHA
    9f4e45c View commit details
    Browse the repository at this point in the history