Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relase/v20.07 - Fix(Alpha): MASA: Make Alpha Shutdown Again (#6313) #6402

Merged
merged 4 commits into from
Sep 4, 2020
Merged

relase/v20.07 - Fix(Alpha): MASA: Make Alpha Shutdown Again (#6313) #6402

merged 4 commits into from
Sep 4, 2020

Commits on Sep 4, 2020

  1. Fix(Alpha): MASA: Make Alpha Shutdown Again (#6313) 

    This PR removes the usage of context.Background() in groups.go and ensures that all the various goroutines exit as intended.

Changes:
* Shutdown SubscribeForUpdates correctly.
* Fix up all the closing conditions.
* Consolidate updaters into one closer
* Update Badger to master
* fix(build): Update ResetAcl args for OSS build.
* chore: Remove TODO comment.

Co-authored-by: Daniel Mai <daniel@dgraph.io>
(cherry picked from commit f1941b3)
    @manishrjain
    manishrjain authored and Ibrahim Jarif committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    47ac86e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'release/v20.07' into ibrahim/r20.07-masa

    Ibrahim Jarif committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    e828d2b View commit details
    Browse the repository at this point in the history

  3. revert badger update

    Ibrahim Jarif committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    393b49a View commit details
    Browse the repository at this point in the history

  4. fix build

    Ibrahim Jarif committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    f9c2726 View commit details
    Browse the repository at this point in the history