Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Enterprise License tests (#5822) #6639

Merged
merged 2 commits into from
Oct 3, 2020

Conversation

antblood
Copy link
Contributor

@antblood antblood commented Oct 2, 2020

Created a file for testing if the license is applied correctly. It contains 3 tests.

  1. Applying expired license, this will get applied but it should not be enabled and user information should be extracted
  2. Applying invalid license, this won't get applied
  3. Applying empty license, this also won't get applied

Co-authored-by: Ibrahim Jarif ibrahim@dgraph.io
(cherry picked from commit 61363d1)


This change is Reviewable

Docs Preview: Dgraph Preview

Created a file for testing if the license is applied correctly. It contains 3 tests.

1. Applying expired license, this will get applied but it should not be enabled and user information should be extracted
2. Applying invalid license, this won't get applied
3. Applying empty license, this also won't get applied

Co-authored-by: Ibrahim Jarif <ibrahim@dgraph.io>
(cherry picked from commit 61363d1)
@antblood antblood requested review from manishrjain and a team as code owners October 2, 2020 21:38
comparing with nil instead of false
Copy link
Contributor

@jarifibrahim jarifibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the code but it's a cherry-pick so LGTM

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @manishrjain)

@antblood antblood merged commit 305190b into release/v20.03 Oct 3, 2020
@joshua-goldstein joshua-goldstein deleted the neeraj/v20.03-licenseUnitTests branch August 11, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants