Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test that after snapshot is applied, GraphQL schema is updated #8619

Merged
merged 10 commits into from
Feb 2, 2023

Conversation

shivaji-dgraph
Copy link
Contributor

Tests automated for following scenarios:

  • After snapshot stream is received from other running alpha , check whether graphql schema is loaded into memory .

Sequence of steps during automation:

  • Stop one alpha container
  • Add data into cluster + apply new graphql schema
  • Start alpha container
  • Check whether the newly started alpha got graphql schema in snapshot.

@CLAassistant
Copy link

CLAassistant commented Jan 19, 2023

CLA assistant check
All committers have signed the CLA.

@shivaji-dgraph shivaji-dgraph marked this pull request as draft January 19, 2023 13:28
@mangalaman93 mangalaman93 changed the title Automated tests to check whether new alpha receives graphql schema, after snapshot is applied to it. Ensure that after snapshot is applied, GraphQL schema is updated Jan 19, 2023
@mangalaman93 mangalaman93 changed the title Ensure that after snapshot is applied, GraphQL schema is updated Add test that after snapshot is applied, GraphQL schema is updated Jan 19, 2023
@shivaji-dgraph shivaji-dgraph changed the title Add test that after snapshot is applied, GraphQL schema is updated fix(tests):Added test that after snapshot is applied check whether GraphQL schema is loaded into memory Jan 19, 2023
@coveralls
Copy link

coveralls commented Jan 19, 2023

Coverage Status

Coverage: 67.169% (+0.2%) from 67.011% when pulling dfa25c6 on shiva/snapshot-test into 8a302b7 on main.

testutil/docker.go Show resolved Hide resolved
testutil/schema.go Show resolved Hide resolved
worker/snapshot_test.go Show resolved Hide resolved
@shivaji-dgraph shivaji-dgraph changed the title fix(tests):Added test that after snapshot is applied check whether GraphQL schema is loaded into memory Add test that after snapshot is applied, GraphQL schema is updated Jan 20, 2023
@shivaji-dgraph shivaji-dgraph marked this pull request as ready for review January 24, 2023 06:44
testutil/docker.go Outdated Show resolved Hide resolved
testutil/docker.go Show resolved Hide resolved
testutil/docker.go Outdated Show resolved Hide resolved
testutil/docker.go Outdated Show resolved Hide resolved
testutil/docker.go Outdated Show resolved Hide resolved
worker/snapshot_test.go Outdated Show resolved Hide resolved
worker/snapshot_test.go Outdated Show resolved Hide resolved
worker/snapshot_test.go Show resolved Hide resolved
worker/snapshot_test.go Outdated Show resolved Hide resolved
worker/snapshot_test.go Show resolved Hide resolved
@mangalaman93 mangalaman93 merged commit 4357fa2 into main Feb 2, 2023
@mangalaman93 mangalaman93 deleted the shiva/snapshot-test branch February 2, 2023 12:50
all-seeing-code pushed a commit that referenced this pull request Feb 8, 2023
#8619)

After snapshot stream is received from other running alpha,
ensure that the new graphql schema is loaded into memory .

Sequence of steps in the test:
 * Stop one alpha container 
 * Add data into cluster + apply new graphql schema 
 * Start alpha container
 * Check whether the newly started alpha got graphql schema in snapshot.
all-seeing-code pushed a commit that referenced this pull request Feb 8, 2023
#8619)

After snapshot stream is received from other running alpha,
ensure that the new graphql schema is loaded into memory .

Sequence of steps in the test:
 * Stop one alpha container 
 * Add data into cluster + apply new graphql schema 
 * Start alpha container
 * Check whether the newly started alpha got graphql schema in snapshot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants