Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): add workaround for multiple groot issue in export-import #8897

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

mangalaman93
Copy link
Contributor

@mangalaman93 mangalaman93 commented Jul 5, 2023

When we perform an export and import into the cluster, this ends up creating two groot users in the cluster. This PR implements a workaround so that two groot users are not created to begin with. With this workaround, now we can also run upgrade tests using ExportImport.

The workaround is as follows. We find the UIDs of groot user and guardian group from the new cluster. We modify the output of the export and replace the UIDs of groot user and guardian group with the UIDs we found in the new cluster.

Closes: DGRAPHCORE-300

@dgraph-bot dgraph-bot added area/testing Testing related issues area/core internal mechanisms go Pull requests that update Go code labels Jul 5, 2023
@mangalaman93 mangalaman93 changed the title dgraphtest: add workaround for multiple groot issue in export-import chore(test): add workaround for multiple groot issue in export-import Jul 5, 2023
When we perform an export and import into the cluster, this ends
up creating two groot users in the cluster. This PR implements
a workaround so that two groot users are not created to begin with.
With this workaround, now we can also run upgrade tests using
ExportImport upgrade strategy.
@all-seeing-code
Copy link
Contributor

When we perform an export and import into the cluster, this ends up creating two groot users in the cluster. This PR implements a workaround so that two groot users are not created to begin with. With this workaround, now we can also run upgrade tests using ExportImport

Closes: DGRAPHCORE-300

What's the work around?

@mangalaman93
Copy link
Contributor Author

When we perform an export and import into the cluster, this ends up creating two groot users in the cluster. This PR implements a workaround so that two groot users are not created to begin with. With this workaround, now we can also run upgrade tests using ExportImport
Closes: DGRAPHCORE-300

What's the work around?

it fixes the UID in the export to the UIDs in the current cluster.

dgraphtest/load.go Show resolved Hide resolved
dgraphtest/load.go Show resolved Hide resolved
Copy link
Contributor

@all-seeing-code all-seeing-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment on -1. Looks good to me.

@mangalaman93 mangalaman93 merged commit 112da99 into main Jul 18, 2023
12 checks passed
@mangalaman93 mangalaman93 deleted the aman/import branch July 18, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core internal mechanisms area/testing Testing related issues go Pull requests that update Go code
Development

Successfully merging this pull request may close these issues.

None yet

5 participants