Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix live loader and add tests for dropall, drop namespace, live load #9063

Merged
merged 3 commits into from
Apr 5, 2024
Merged

fix live loader and add tests for dropall, drop namespace, live load #9063

merged 3 commits into from
Apr 5, 2024

Conversation

shivaji-dgraph
Copy link
Contributor

No description provided.

@shivaji-dgraph shivaji-dgraph requested a review from a team as a code owner April 4, 2024 09:16
@dgraph-bot dgraph-bot added area/testing Testing related issues area/core internal mechanisms go Pull requests that update Go code labels Apr 4, 2024
@CLAassistant
Copy link

CLAassistant commented Apr 5, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ shivaji-dgraph
❌ Harshil Goel

Harshil Goel seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

gajanan-dgraph
gajanan-dgraph approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@gajanan-dgraph gajanan-dgraph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parser changes are correct. Thanks for fixing tests.

@harshil-goel harshil-goel merged commit 2aeef65 into main Apr 5, 2024
10 checks passed
@harshil-goel harshil-goel deleted the shiva/test-run branch April 5, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gajanan-dgraph gajanan-dgraph gajanan-dgraph approved these changes

Assignees
No one assigned
Labels
area/core internal mechanisms area/testing Testing related issues go Pull requests that update Go code
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@shivaji-dgraph @CLAassistant @gajanan-dgraph @dgraph-bot @harshil-goel