Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Understand why RSS increases during manual allocs #186

Merged
merged 27 commits into from
Aug 28, 2020

Conversation

manishrjain
Copy link
Contributor

@manishrjain manishrjain commented Aug 23, 2020

$ go build . && ./memtest

This program cycles memory allocations so they allocate 16 GB, then deallocate until 1 GB, and repeat. Somehow this causes RSS memory to spike in Go. The corresponding C program does not exhibit this behavior. Don't understand why!

This change is Reviewable

Copy link
Contributor

@danielmai danielmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 10 of 10 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@danielmai danielmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Nice godocs.

Reviewable status: 10 of 11 files reviewed, all discussions resolved (waiting on @danielmai)

@manishrjain manishrjain marked this pull request as ready for review August 28, 2020 21:55
@manishrjain manishrjain merged commit 2ce4f8f into master Aug 28, 2020
@manishrjain manishrjain deleted the mrjn/disable-free branch August 28, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants