Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add histogram.Mean() method #188

Merged
merged 2 commits into from
Sep 1, 2020
Merged

Add histogram.Mean() method #188

merged 2 commits into from
Sep 1, 2020

Conversation

jarifibrahim
Copy link
Contributor

@jarifibrahim jarifibrahim commented Aug 25, 2020 •
edited by manishrjain
Loading

This change is Reviewable

@jarifibrahim
Copy link
Contributor Author

The teamcity build is failing because the test.sh script is missing on master.

martinmr
martinmr approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @anurags92, @karlmcguire, and @manishrjain)

@jarifibrahim jarifibrahim merged commit 9d26abc into master Sep 1, 2020
@jarifibrahim jarifibrahim deleted the ibrahim/hist-mean branch September 1, 2020 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmr martinmr martinmr approved these changes

@all-seeing-code all-seeing-code all-seeing-code approved these changes

@karlmcguire karlmcguire Awaiting requested review from karlmcguire

@manishrjain manishrjain Awaiting requested review from manishrjain

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jarifibrahim @martinmr @all-seeing-code