Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(btree): make delete below delete values that are less than lo #211

Merged
merged 1 commit into from
Oct 28, 2020
Merged

fix(btree): make delete below delete values that are less than lo #211

merged 1 commit into from
Oct 28, 2020

Conversation

NamanJain8
Copy link
Contributor

@NamanJain8 NamanJain8 commented Oct 27, 2020 •
edited by manishrjain
Loading

This PR changes the compact to delete all the keys with values less than lo.

This change is Reviewable

manishrjain
manishrjain approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jarifibrahim and @martinmr)

@NamanJain8 NamanJain8 merged commit 0eff948 into master Oct 28, 2020
@NamanJain8 NamanJain8 deleted the naman/delete-below branch October 28, 2020 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manishrjain manishrjain manishrjain approved these changes

@jarifibrahim jarifibrahim Awaiting requested review from jarifibrahim

@martinmr martinmr Awaiting requested review from martinmr

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NamanJain8 @manishrjain