Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(buffer): add a parent directory field in z.Buffer #215

Merged
merged 3 commits into from
Nov 3, 2020
Merged

chore(buffer): add a parent directory field in z.Buffer #215

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bfb5232
add buffer directory
NamanJain8 Nov 2, 2020
980e00c
add dir to z.Buffer struct
NamanJain8 Nov 3, 2020
314ccd6
create API NewBufferWithDir
NamanJain8 Nov 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions z/buffer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ type Buffer struct {
fd *os.File
bufType BufferType
autoMmapAfter int
dir string
}

type BufferType int
Expand All @@ -71,18 +72,26 @@ const (
// smallBufferSize is an initial allocation minimal capacity.
const smallBufferSize = 64

// Newbuffer is a helper utility, which creates a virtually unlimited Buffer in UseCalloc mode.
// NewBuffer is a helper utility, which creates a virtually unlimited Buffer in UseCalloc mode.
func NewBuffer(sz int) *Buffer {
buf, err := NewBufferWith(sz, 256<<30, UseCalloc)
buf, err := NewBufferWithDir(sz, 256<<30, UseCalloc, "")
if err != nil {
log.Fatalf("while creating buffer: %v", err)
}
return buf
}

// NewBufferWith would allocate a buffer of size sz upfront, with the total size of the buffer not
// exceeding maxSz. Both sz and maxSz can be set to zero, in which case reasonable defaults would be
// used. Buffer can't be used without initialization via NewBuffer.
func NewBufferWith(sz, maxSz int, bufType BufferType) (*Buffer, error) {
buf, err := NewBufferWithDir(sz, maxSz, bufType, "")
return buf, err
}

func (b *Buffer) doMmap() error {
curBuf := b.buf
fd, err := ioutil.TempFile("", "buffer")
fd, err := ioutil.TempFile(b.dir, "buffer")
if err != nil {
return err
}
Expand All @@ -104,10 +113,11 @@ func (b *Buffer) doMmap() error {
return nil
}

// NewBufferWith would allocate a buffer of size sz upfront, with the total size of the buffer not
// exceeding maxSz. Both sz and maxSz can be set to zero, in which case reasonable defaults would be
// used. Buffer can't be used without initialization via NewBuffer.
func NewBufferWith(sz, maxSz int, bufType BufferType) (*Buffer, error) {
// NewBufferWithDir would allocate a buffer of size sz upfront, with the total size of the buffer
// not exceeding maxSz. Both sz and maxSz can be set to zero, in which case reasonable defaults
// would be used. Buffer can't be used without initialization via NewBuffer. The buffer is created
// inside dir. The caller should take care of existence of dir.
func NewBufferWithDir(sz, maxSz int, bufType BufferType, dir string) (*Buffer, error) {
if sz == 0 {
sz = smallBufferSize
}
Expand All @@ -120,6 +130,7 @@ func NewBufferWith(sz, maxSz int, bufType BufferType) (*Buffer, error) {
curSz: sz,
maxSz: maxSz,
bufType: UseCalloc, // by default.
dir: dir,
}

switch bufType {
Expand Down