Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(buffer): Make padding internal to z.buffer #216

Merged
merged 2 commits into from
Nov 4, 2020
Merged

fix(buffer): Make padding internal to z.buffer #216

merged 2 commits into from
Nov 4, 2020

Conversation

ahsanbarkati
Copy link
Contributor

@ahsanbarkati ahsanbarkati commented Nov 3, 2020 •
edited by manishrjain
Loading

The caller of the API should not be aware of the padding. It should be handled internally.

This change is Reviewable

jarifibrahim
jarifibrahim approved these changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@jarifibrahim jarifibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test for it.

@ahsanbarkati ahsanbarkati merged commit d8d5371 into master Nov 4, 2020
@ahsanbarkati ahsanbarkati deleted the ahsan/buffer-fix branch November 4, 2020 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarifibrahim jarifibrahim jarifibrahim approved these changes

@manishrjain manishrjain Awaiting requested review from manishrjain

@martinmr martinmr Awaiting requested review from martinmr

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahsanbarkati @jarifibrahim