Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(MmapFile): Don't error out if fileSize > sz #224

Merged
merged 1 commit into from
Nov 10, 2020
Merged

fix(MmapFile): Don't error out if fileSize > sz #224

merged 1 commit into from
Nov 10, 2020

Conversation

jarifibrahim
Copy link
Contributor

@jarifibrahim jarifibrahim commented Nov 10, 2020 •
edited by manishrjain
Loading

This change is Reviewable

ajeetdsouza
ajeetdsouza approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@ajeetdsouza ajeetdsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @manishrjain and @martinmr)

@jarifibrahim jarifibrahim merged commit f3ca035 into master Nov 10, 2020
@jarifibrahim jarifibrahim deleted the ibrahim/file-open branch November 10, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajeetdsouza ajeetdsouza ajeetdsouza approved these changes

@manishrjain manishrjain Awaiting requested review from manishrjain

@martinmr martinmr Awaiting requested review from martinmr

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jarifibrahim @ajeetdsouza