Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ZeroOut to use a simple for loop. #231

Merged
merged 3 commits into from
Nov 20, 2020
Merged

Updated ZeroOut to use a simple for loop. #231

merged 3 commits into from
Nov 20, 2020

Conversation

chewxy
Copy link
Contributor

@chewxy chewxy commented Nov 19, 2020

Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @chewxy, @jarifibrahim, @manishrjain, and @martinmr)


z/z.go, line 138 at r1 (raw file):

	}
	n := end - start
	if n <= 0 {

if end - start <= 0


z/z.go, line 143 at r1 (raw file):

	b := dst[start:end]
	for i := range b {
		b[i] = 0

b[i] = 0x00

Copy link
Contributor Author

@chewxy chewxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @jarifibrahim, @manishrjain, and @martinmr)


z/z.go, line 138 at r1 (raw file):

Previously, manishrjain (Manish R Jain) wrote…

if end - start <= 0

Done.


z/z.go, line 143 at r1 (raw file):

Previously, manishrjain (Manish R Jain) wrote…

b[i] = 0x00

Done.

@chewxy chewxy merged commit 729b324 into master Nov 20, 2020
@joshua-goldstein joshua-goldstein deleted the chewxy/zeroout branch September 15, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants