Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect unit test coverage depiction #245

Merged

Conversation

checkaayush
Copy link
Contributor

@checkaayush checkaayush commented Jan 24, 2021

Unit test coverage report from gocover suggests a 71% test coverage but the current badge depicts 100% test coverage, which isn't the case. This fixes the badge.


This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Jan 24, 2021

CLA assistant check
All committers have signed the CLA.

@checkaayush
Copy link
Contributor Author

@jarifibrahim Could you please take a look at this? Thanks.

Copy link
Contributor

@jarifibrahim jarifibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @checkaayush 🎉

@jarifibrahim jarifibrahim merged commit 426327c into dgraph-io:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants