feat(super-flags): Add GetPath method in superflags #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahsanbarkati
requested review from
jarifibrahim,
manishrjain and
martinmr
as code owners
karlmcguire
approved these changes
Mar 9, 2021
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jarifibrahim, @manishrjain, and @martinmr)
|
Does this address row #34 in Haqathon sheet? If not, might be a good place to improve that. |
If we want to support filenames with semi-colons then we will have to change the separator itself. Not sure if we expect filenames with semi-colons. |
jarifibrahim
approved these changes
Mar 10, 2021
ajeetdsouza
suggested changes
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In super-flags, the file-paths are given within quotes. So the shell is not able to expand the paths having
~to/home/user/....This PR adds
GetPath()method on super flags which expands the paths having~to/home/user/...For example:
dgraph alpha --acl="secret_file=~/hmac-secret"the above command throws an error that path doesn't exists even if it exists.
This change is