feat(configurable cleanup ticker): add config for cleanup ticker duration
#342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhvikash11
requested review from
akon-dey and
joshua-goldstein
as code owners
|
|
|
@joshua-goldstein can you please review the pr, I want to use this library as app-cache in prod. |
|
@akon-dey can you please review the pr |
mangalaman93
approved these changes
Aug 31, 2023
mangalaman93
force-pushed
the
cleanup_ticker_config
branch
from
45549dc
to
ba4bb09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Cleanup ticker to remove entries for expired keys taking a lot of CPU cycles around 90% in the case of pod with 1.6 CPU
Solution
Making the duration of the cleanup ticker configurable so users can configure it to higher values and can save on CPU cycles.