Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable mmap size check on arm arch as well as arm64 #366

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

requilence
Copy link
Contributor

In #281 mmap size check has been disabled for the ARM64 arch.

But we at anytype quite often face the same problem on the arm arch on Android devices (armeabi-v7a target) with the latest badger v4.2.0 and latest ristretto v0.1.1.

memtables error: while opening fid: 1 error: while updating skiplist error: mremap size mismatch: requested: 1479692 got: 67108864

This PR extends the #281 to cover all arm architectures.

Here is one more mention of this issue
dgraph-io/badger#2027 (comment)

It would also make sense to create the PR on top of v0.1.1 release, but there is not release branch to base on

Copy link
Contributor

@mangalaman93 mangalaman93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mangalaman93 mangalaman93 merged commit a9fc219 into dgraph-io:main Dec 11, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants