Release 3.0.0 #77
Release 3.0.0 #77
Conversation
Must implement interface Claims, which means there is a Valid method.
Only verify claim if it isn't a default value. The alternative here would be to use pointers in the Claims structure then we would know which were nil, or if they were explicitly set to zero in the claim section Updated MapClaim implementation to check for existance of keys before using them. If they don't exists, validation functions simply return true.
Still need to add a test that utilizes the defaults of the structured object. Update Cmdline app Update package reference for PR. Update examples
|
This is just about ready to land. As soon as #137 has been looked at, we can complete the README updates and ship it. Any remaining issues to be resolved? |
|
Has the issue I mentioned here now been fixed? #73 Thanks! |
|
@StephanDollberg That thread is super long, but I believe we have addressed all the issues. There are several example uses you can review to see usage. |
Add new interface Extractor for making token extraction pluggable
|
Oh yeah sorry. It was the issue with https://github.com/dgrijalva/jwt-go/blob/release_3_0_0/token.go#L33 having to return a pointer to |
|
That has been solved, though it's not super elegant. I ended up special casing it. I think it's ok, but we can watch it. -dave
|
|
Anything I can do to help push 3.0 out? |
|
There are no remaining issues for 3.0.0. Shall we ship it (finally)? |
|
The only thing that got left out is support for leeway. The documentation says about it:
I think we can add support for this by modifying |
|
Actually, the change proposed in #131 would enable things like iss validation, etc in the future. Let me see how hard it would be... |
|
See #139 |
See #75
[]bytewhen using RSA signing methodsParseFromRequestto a subpackage.