Skip to content

Commit

Permalink
Merge pull request getkirby#6001 from getkirby/v4/fix/todo-comments
Browse files Browse the repository at this point in the history
Postpone todo comments
  • Loading branch information
bastianallgeier authored Nov 24, 2023
2 parents 02eea26 + 72e8184 commit bdd6b6a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/Cms/Auth/TotpChallenge.php
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public static function isAvailable(User $user, string $mode): bool
* @param array $options Details of the challenge request:
* - 'mode': Purpose of the code ('login', 'password-reset' or '2fa')
* - 'timeout': Number of seconds the code will be valid for
* @todo set return type to null, once PHP 8.0 is dropped
* @todo set return type to `null` once support for PHP 8.1 is dropped
*/
public static function create(User $user, array $options): string|null
{
Expand Down
4 changes: 2 additions & 2 deletions src/Cms/Collections.php
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ public function __call(string $name, array $arguments = [])
* Loads a collection by name if registered
*
* @return \Kirby\Toolkit\Collection|null
* @todo 4.0 Add deprecation warning when anything else than a Collection is returned
* @todo 5.0 Add return type declaration
* @todo 5.0 Add deprecation warning when anything else than a Collection is returned
* @todo 6.0 Add PHP return type declaration for `Toolkit\Collection`
*/
public function get(string $name, array $data = [])
{
Expand Down

0 comments on commit bdd6b6a

Please sign in to comment.