[ANDROAPP-6329] Coordiantes drag and drop capture #3807
+2,534
−328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo <pablo@dhis2.org>
Signed-off-by: Pablo <pablo@dhis2.org>
Signed-off-by: Pablo <pablo@dhis2.org>
Signed-off-by: Pablo <pablo@dhis2.org>
Signed-off-by: Pablo <pablo@dhis2.org>
Signed-off-by: Pablo <pablo@dhis2.org>
Signed-off-by: Pablo <pablo@dhis2.org>
Signed-off-by: Pablo <pablo@dhis2.org>
Signed-off-by: Pablo <pablo@dhis2.org>
Signed-off-by: Pablo <pablo@dhis2.org>
andresmr
reviewed
Oct 3, 2024
| @@ -6,6 +6,9 @@ import org.hisp.dhis.android.core.D2 | |||
| import org.hisp.dhis.android.core.map.layer.MapLayerImageryProvider | |||
|
|
|||
| class MapStyleConfiguration(private val d2: D2) { | |||
|
|
|||
| private val canCaptureManually by lazy { true } | |||
There was a problem hiding this comment.
I'm not sure why this is lazy if is not assigned
There was a problem hiding this comment.
It is to make it ready for ANDROAPP-6230. I've would have added a TODO comment, but sonnarcloud did not like it XD
Signed-off-by: Pablo <pablo@dhis2.org>
Signed-off-by: Pablo <pablo@dhis2.org>
Signed-off-by: Pablo <pablo@dhis2.org>
Signed-off-by: Pablo <pablo@dhis2.org>
Signed-off-by: Pablo <pablo@dhis2.org>
Signed-off-by: Pablo <pablo@dhis2.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and include the related jira issue if it exists.
[ jira issue ](https://dhis2.atlassian.net/browse/ANDROAPP-
Solution description
If this PR is a fix include a brief description on how the issue is solved.
Covered unit test cases
Describe the tests that you ran to verify your changes.
Where did you test this issue?
Which Android versions did you test this issue?
Checklist