feat: new Earth Engine format and functions (DHIS2-16097) #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turban
changed the title
turban
changed the title
BRaimbault
reviewed
Jun 26, 2024
BRaimbault
reviewed
Jul 5, 2024
There was a problem hiding this comment.
The changes make sense to me.
There is quite a bit to check though, on a codebase I was not familiar with in the first place.
- I propose to go through extensive testing once we get all the pieces together, including adding other GEE layers in maps-app.
- It seems making it work with maps-app-v39 should not be too complicated but it has to be included in the testing.
jenniferarnesen
approved these changes
Jul 9, 2024
* fix: only use mask for ee tiles * feat: new unmask aggregation param * Allow mask value to be passed in
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://dhis2.atlassian.net/browse/DHIS2-16097
Depends on dhis2/maps-app#3158 if you want to test this PR in DHIS2 Maps.
BREAKING CHANGE
Requires some changes in the options passed to the EE layer if we want to use the latest version of @dhis2/maps-gl in released versions of DHIS2 Maps. The changes required are shown in this PR: https://github.com/dhis2/maps-app/pull/3067/files
Main changes:
useCentroidoption to only include grid cells where the centroid is within the feature (used for population layers)Hard to add unit tests as most of the code is running in the GEE cloud. Easier to add tests that the various layers load in DHIS2 Maps.
Currently, we support 3 common GEE formats, "Image", "ImageCollection" and "FeatureCollection" - an "Unknown format" error will be returned if another format is used (but this should not happen when we control the EE layer configs):