Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of CI testing on Apple Silicon-based devices #8000

Open
NlightNFotis opened this issue Nov 7, 2023 · 2 comments · May be fixed by #8382
Open

Lack of CI testing on Apple Silicon-based devices #8000

NlightNFotis opened this issue Nov 7, 2023 · 2 comments · May be fixed by #8382
Labels
aws Bugs or features of importance to AWS CBMC users CI pending merge Tests

Comments

@NlightNFotis
Copy link
Contributor

Hello,

I'm writing this message to raise awareness of a current situation with regard to our CI configuration and our build processes.

We're currently lacking CI checks for systems based on Apple Silicon (M1, M2, M3, etc). This has caused a number of PRs being merged recently that while good on other platforms (i.e. passing all our existing checks) were failing on Apple Silicon devices, causing our develop branch on
the platform to fail.

The consequences of that have been thus far variable, ranging from minor nuisance to build-breaking bugs that failed on distributor's CI pipelines such as Homebrew's.

The reason for the current situation, from a historical standpoint has been twofold:

  • Low market penetration/perceived importance of the Apple Silicon platform
  • Lack of available CI runners on Github Actions.

Both of these situations have changed as of late:

Unfortunately, Github has only released the runners as part of the so called "large" runners, which require additional payment (normal runners are free for open source projects like CBMC), which requires us to do a cost-analysis (as they are charged on a per-minute of runtime basis) before we can activate them, with any decision unable to be made before we get there.


As a temporary remedy, and in-lack of a CI array for the platform, we would strongly recommend that all PRs should have a note if they have been tested on an Apple Silicon-based device. If there is no test on Apple Silicon then the PR should not be merged. You can ping @NlightNFotis and @esteffin who can test on Apple silicon if you do not have the resources yourself.

@NlightNFotis
Copy link
Contributor Author

CCing people we have discussed this before with and others who may not have heard about this issue yet to raise awareness about the problem:

@feliperodri @tautschnig @kroening @martin-cs @remi-delmas-3000

@feliperodri feliperodri added the aws Bugs or features of importance to AWS CBMC users label Nov 7, 2023
@tautschnig
Copy link
Collaborator

In Kani, we have so far chosen to only check our release builds on this platform. Maybe that's a more feasible middle ground? At present, @NlightNFotis and @esteffin are involved in producing the release with high probability, so this might be practical?

tautschnig added a commit to tautschnig/cbmc that referenced this issue Jul 12, 2024
This will exercise builds on ARM/Apple Silicon.

Fixes: diffblue#8000
@tautschnig tautschnig linked a pull request Jul 12, 2024 that will close this issue
3 tasks
tautschnig added a commit to tautschnig/cbmc that referenced this issue Jul 24, 2024
This will exercise builds on ARM/Apple Silicon.

Fixes: diffblue#8000
tautschnig added a commit to tautschnig/cbmc that referenced this issue Aug 22, 2024
This will exercise builds on ARM/Apple Silicon.

Fixes: diffblue#8000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws Bugs or features of importance to AWS CBMC users CI pending merge Tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants