Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression cleanup: don't repeatedly remove the same file #8369

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

tautschnig
Copy link
Collaborator

There is no need to remove tests.log as many times as we have directories.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

There is no need to remove `tests.log` as many times as we have
directories.
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.34%. Comparing base (66ae03f) to head (1918cde).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8369   +/-   ##
========================================
  Coverage    78.34%   78.34%           
========================================
  Files         1726     1726           
  Lines       188437   188437           
  Branches     18244    18244           
========================================
  Hits        147638   147638           
  Misses       40799    40799           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kroening kroening merged commit b3f1e71 into diffblue:develop Jul 10, 2024
39 of 40 checks passed
@tautschnig tautschnig deleted the fix-cleanup branch July 10, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants