Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI jobs: upgrade CVC5 from 1.0.0 to 1.1.2 #8383

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

tautschnig
Copy link
Collaborator

Since version 1.0.1, CVC5 also releases a binary for macOS ARM, which will enable CBMC CI runs on that platform (see
#8382). More recent releases of CVC5, however, have also moved to releasing zip archives rather than single binaries. This necessitates an overhaul of the rules to download and install CVC5 beyond just changing the version number.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig added the CI label Jul 15, 2024
@tautschnig tautschnig self-assigned this Jul 15, 2024
@tautschnig tautschnig force-pushed the upgrade-cvc5 branch 3 times, most recently from 9621d9c to 68e9543 Compare July 15, 2024 09:54
@tautschnig tautschnig assigned peterschrammel and TGWDB and unassigned tautschnig Jul 15, 2024
@tautschnig tautschnig marked this pull request as ready for review July 15, 2024 09:55
@tautschnig tautschnig requested review from peterschrammel and a team as code owners July 15, 2024 09:55
Since version 1.0.1, CVC5 also releases a binary for macOS ARM, which
will enable CBMC CI runs on that platform (see
diffblue#8382). More recent releases of
CVC5, however, have also moved to releasing zip archives rather than
single binaries. This necessitates an overhaul of the rules to download
and install CVC5 beyond just changing the version number.
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.32%. Comparing base (2523f2c) to head (3e38d2c).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8383   +/-   ##
========================================
  Coverage    78.32%   78.32%           
========================================
  Files         1726     1726           
  Lines       188506   188506           
  Branches     18249    18249           
========================================
  Hits        147646   147646           
  Misses       40860    40860           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig merged commit bf58af8 into diffblue:develop Jul 24, 2024
39 of 40 checks passed
@tautschnig tautschnig deleted the upgrade-cvc5 branch July 24, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants