Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom config except for max-nondet-array-length #24

Merged
merged 1 commit into from
Oct 26, 2018

Conversation

JohnLBergqvist
Copy link
Contributor

@JohnLBergqvist JohnLBergqvist commented Oct 25, 2018

This removes the custom configuration except for max-nondet-array-length (required to unwind checkTicTacToe enough times)

I have confirmed that coverage counts are still the same as before.

Copy link
Contributor

@rjmunro rjmunro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the substance of this, but the description seems completely off.

It's really something like "Remove all custom config except max-nondet-array-length".

Copy link

@jgwilson42 jgwilson42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you update the PR title and description to match the change that has been made?

@JohnLBergqvist JohnLBergqvist changed the title java-max-input-array-length argument is now max-nondet-array-length Remove custom config except for max-nondet-array-length Oct 26, 2018
@JohnLBergqvist
Copy link
Contributor Author

@jgwilson42 I have updated the PR title & description

@JohnLBergqvist JohnLBergqvist merged commit eaf59cd into master Oct 26, 2018
@JohnLBergqvist JohnLBergqvist deleted the restore-original-diffblue.yml branch October 26, 2018 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants