Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add maven-surefile-plugin #26

Merged
merged 1 commit into from
Nov 20, 2018
Merged

Add maven-surefile-plugin #26

merged 1 commit into from
Nov 20, 2018

Conversation

yumibagge
Copy link
Contributor

The maven-surefile-plugin is now needed to perform maven test due to a
bug in the openjdk-8 package.

Add maven-surefile-plugin
374ddba 
The maven-surefile-plugin is now needed to perform maven test due to a
bug in the openjdk-8 package.
@yumibagge
Copy link
Contributor Author

I have tested mvn test on local and also on platform by cloning the branch.

@paulkennethkent
Copy link
Contributor

@yumibagge did you replicate this issue on platform or locally?

@yumibagge
Copy link
Contributor Author

@paulkennethkent, the issue is reproducible on local. Sorry, I was not stating the test I performed before requesting... Tests I conducted are

  • run mvn test on my branch java-demo
  • zip the java-demo, uploaded to platform, downloaded tests, then run mvn test on local.
  • create project from java-demo/branch, downloaded tests, then run mvn test on local.
    Does it answer your question?

jgwilson42
jgwilson42 suggested changes Nov 9, 2018
View reviewed changes
Copy link

@jgwilson42 jgwilson42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question.

pom.xml
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<project xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this line need to change?

Copy link
Contributor Author

@yumibagge yumibagge Nov 10, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the change is necessary (At least it is not intentional .. next time I will be extra careful). I think what had happen was I reformatted using IntellJ checkstyle plugin (based on google style), it reformatted this way. I am happy to return to the original if you think the original format is better.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We try to conform to Google coding standard so this seems like a logical change?

@yumibagge yumibagge merged commit 7287e32 into master Nov 20, 2018
@allredj allredj deleted the yb/java-demo-pom-surefire branch March 9, 2020 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulkennethkent paulkennethkent paulkennethkent approved these changes

@jgwilson42 jgwilson42 jgwilson42 approved these changes

@JohnLBergqvist JohnLBergqvist Awaiting requested review from JohnLBergqvist

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yumibagge @paulkennethkent @jgwilson42