Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change package to io.diffblue.javademo #35

Merged
merged 2 commits into from
Feb 19, 2020
Merged

Conversation

allredj
Copy link

@allredj allredj commented Jan 21, 2020

fuzztest does not like the com.diffblue prefix.

@allredj
Copy link
Author

allredj commented Jan 21, 2020

If this change goes through, user documentation will have to be updated.

Copy link

@jeannielynnmoulton jeannielynnmoulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good idea to me, but I think some tests and maybe some CIs will have to be updated on cover-ui and maybe elsewhere? @yumibagge

@rjmunro
Copy link
Contributor

rjmunro commented Jan 23, 2020

Wasn't the problem that required this fixed? If it was, it would be better not to make this change, because it would be good to spot this problem if it recurs.

I am successfully generating tests for com.diffblue.* code in this experimental branch:
https://github.com/diffblue/cover/pull/91

@allredj
Copy link
Author

allredj commented Jan 23, 2020

I don't think so. @cesaro?

@peterschrammel
Copy link
Member

It hasn't been fixed yet. It creates tests with assertions for return values, but not for side effects afaik.

@allredj allredj merged commit 4047c05 into master Feb 19, 2020
@allredj allredj deleted the allredj/change-package branch February 19, 2020 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants