Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add new orange and green base colors #2335

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Conversation

Thunear
Copy link
Collaborator

@Thunear Thunear commented Aug 27, 2024

Adding new base colors for orange and green so the contrast color becomes white.

image

Copy link

changeset-bot bot commented Aug 27, 2024

⚠️ No Changeset found

Latest commit: 0dc2eae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 27, 2024

Preview deployments for this pull request:

📖 Storybook 27. Aug 2024 - 14:09 (Norwegian time)

See all deployments at https://dev.designsystemet.no

@Thunear Thunear marked this pull request as ready for review August 27, 2024 11:13
@Barsnes
Copy link
Member

Barsnes commented Aug 27, 2024

This does not update any tokens, should it?
image

@Thunear
Copy link
Collaborator Author

Thunear commented Aug 27, 2024

This does not update any tokens, should it? image

No. This is just so that Lasse kan copy the JSON into Figma. He will then generate new tokens that will be pushed to code in a PR later.

@mimarz
Copy link
Collaborator

mimarz commented Aug 27, 2024

This will be a merge conflict with #2290

@mimarz
Copy link
Collaborator

mimarz commented Aug 27, 2024

Fixed the conflict, is it ok @Thunear ?

@mimarz mimarz merged commit ca4c1b3 into next Aug 27, 2024
4 checks passed
@mimarz mimarz deleted the chore/update-colors branch August 27, 2024 12:11
@Thunear
Copy link
Collaborator Author

Thunear commented Aug 27, 2024

Yes this is great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants