Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Accordion): implement css adjustments and native details #2363

Merged
merged 32 commits into from
Sep 16, 2024

Conversation

eirikbacker
Copy link
Contributor

@eirikbacker eirikbacker commented Sep 2, 2024

Question: It is now implemented so search-in-page only works when using defaultOpen, as a controlled open should not be affected by user interaction. Just checking - does this make sense to you guys as well? :)

Copy link

changeset-bot bot commented Sep 2, 2024

⚠️ No Changeset found

Latest commit: 35cac99

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@eirikbacker eirikbacker self-assigned this Sep 2, 2024
Copy link
Contributor

github-actions bot commented Sep 2, 2024

Preview deployments for this pull request:

📖 Storybook 16. Sep 2024 - 15:20 (Norwegian time)

🖥 Storefront 16. Sep 2024 - 15:21 (Norwegian time)

Copy link
Contributor

github-actions bot commented Sep 2, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 63.69% 4593 / 7211
🔵 Statements 63.69% 4593 / 7211
🔵 Functions 86.17% 162 / 188
🔵 Branches 75.6% 592 / 783
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/react/src/components/Accordion/AccordionContent.tsx 100% 100% 100% 100%
packages/react/src/components/Accordion/AccordionHeading.tsx 100% 100% 100% 100%
packages/react/src/components/Accordion/AccordionItem.tsx 78.66% 64.7% 80% 78.66% 61, 64, 103-116
Generated in workflow #345

@eirikbacker eirikbacker changed the title fix: start implementing css adjustments and native details fix(Accordion): start implementing css adjustments and native details Sep 2, 2024
@eirikbacker
Copy link
Contributor Author

Closes #2364

Copy link
Contributor

github-actions bot commented Sep 9, 2024

Preview deployments for this pull request:

Theme 16. Sep 2024 - 13:33 (Norwegian time)

@eirikbacker eirikbacker marked this pull request as ready for review September 9, 2024 08:18
packages/css/accordion.css Outdated Show resolved Hide resolved
@eirikbacker eirikbacker marked this pull request as draft September 11, 2024 07:28
@eirikbacker eirikbacker marked this pull request as ready for review September 13, 2024 13:24
@eirikbacker eirikbacker changed the title fix(Accordion): start implementing css adjustments and native details fix(Accordion): implement css adjustments and native details Sep 13, 2024
Copy link
Contributor

Preview deployments for this pull request:

Theme 16. Sep 2024 - 15:18 (Norwegian time)

1 similar comment
Copy link
Contributor

Preview deployments for this pull request:

Theme 16. Sep 2024 - 15:18 (Norwegian time)

Copy link
Contributor

Preview deployments for this pull request:

Theme 16. Sep 2024 - 15:19 (Norwegian time)

@eirikbacker eirikbacker merged commit 595a75b into next Sep 16, 2024
8 checks passed
@eirikbacker eirikbacker deleted the fix/css-native-accordion branch September 16, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Use of <details> in Accordion
2 participants