Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Heading): default level is now 2 #2378

Merged
merged 4 commits into from
Sep 10, 2024
Merged

feat(Heading): default level is now 2 #2378

merged 4 commits into from
Sep 10, 2024

Conversation

Barsnes
Copy link
Member

@Barsnes Barsnes commented Sep 5, 2024

resolves #2358

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 5, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 6cebf42

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@digdir/designsystemet-react Patch
@digdir/designsystemet Patch
@digdir/designsystemet-css Patch
@digdir/designsystemet-theme Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024 •
edited
Loading

Preview deployments for this pull request:

📖 Storybook 5. Sep 2024 - 14:05 (Norwegian time)

See all deployments at https://dev.designsystemet.no

@Barsnes Barsnes marked this pull request as ready for review September 5, 2024 11:38
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 65.05% 4853 / 7460
🔵 Statements 65.05% 4853 / 7460
🔵 Functions 83.22% 129 / 155
🔵 Branches 75.75% 606 / 800
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/react/src/components/Typography/Heading/Heading.tsx 100% 100% 100% 100%
Generated in workflow #96

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024 •
edited
Loading

Preview deployments

Theme 5. Sep 2024 - 14:05 (Norwegian time)

mimarz
mimarz requested changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you forget to update the actual default value (L34)? 😅

@eirikbacker
Copy link
Contributor

Nice! ☺️

  • should we then update everywhere Heading level={2} is used?
  • should we double check so everything where Heading does not have level specified (as this is now changes level)?

@Barsnes
Copy link
Member Author

Barsnes commented Sep 6, 2024

Nice! ☺️

  • should we then update everywhere Heading level={2} is used?
  • should we double check so everything where Heading does not have level specified (as this is now changes level)?

I think it's fine if we keep level={2}, it makes a bit more readable for everyone :)

I did a quick check through places we have used Heading, and it seems like we set the level most of the time. Testsites we don't need to update.

@mimarz mimarz merged commit 8cdd5c5 into next Sep 10, 2024
6 checks passed
@mimarz mimarz deleted the chore/heading-level branch September 10, 2024 06:32
Barsnes added a commit that referenced this pull request Sep 11, 2024
@Barsnes
feat(Heading): default level is now 2 (#2378)
660a1df 
resolves #2358
@github-actions github-actions bot mentioned this pull request Sep 11, 2024
Merged
mimarz pushed a commit that referenced this pull request Sep 17, 2024
@github-actions
chore: new release candidate (next) (#2361)
5bf8c21 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to next, this PR will
be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`next` is currently in **pre mode** so this branch has prereleases
rather than normal releases. If you want to exit prereleases, run
`changeset pre exit` on `next`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## @digdir/designsystemet-css@1.0.0-next.33

### Patch Changes

- Pagination: Use data attrs instead of class names
([#2395](#2395))

- Badge: Style using css attributes
([#2391](#2391))

- TableHeaderCell: Remove `sortable` prop, `sort` now handles this
([#2393](#2393))

- dropdownmenu: Style using data attributes
([#2387](#2387))

- Chip: Text color is now `accent`
([#2371](#2371))

- List: Remove `List.Root` and `List.Heading`, which changes API
([#2348](#2348))

- Alert, Avatar, Button, Divider, Link: Use data-attributes for variant,
size and color and move icons to CSS
([#2313](#2313))

- Box: Remove component
([#2372](#2372))

- Popover: ([#2369](#2369))

    -   Rename `<Popover.Root>` to `<Popover.Context>`
- use Popover API, allowing `<Popover>` to be used without
`Popover.Context`
    -   Remove `portal` prop

- Tooltip: Only expose background css variable
([#2389](#2389))

- Switch: don't show check when not checked in readonly
([#2377](#2377))

- Select: Rename from `NativeSelect`
([#2404](#2404))

- Accordion: Now uses details and summary HTML elements
([`5d1c5062b526e6829c322ce66c6df08568bb9f63`](5d1c506))

- Spinner: Style using data attributes
([#2390](#2390))

- Avatar: new component
([#2312](#2312))

- Tag: Make neutral default color in CSS
([#2397](#2397))

- Card: Use data attrs
([#2398](#2398))

## @digdir/designsystemet-react@1.0.0-next.33

### Patch Changes

- Pagination: Use data attrs instead of class names
([#2395](#2395))

- Badge: Style using css attributes
([#2391](#2391))

- TableHeaderCell: Remove `sortable` prop, `sort` now handles this
([#2393](#2393))

- dropdownmenu: Style using data attributes
([#2387](#2387))

- List: Remove `List.Root` and `List.Heading`, which changes API
([#2348](#2348))

- Alert, Avatar, Button, Divider, Link: Use data-attributes for variant,
size and color and move icons to CSS
([#2313](#2313))

- Box: Remove component
([#2372](#2372))

- Popover: ([#2369](#2369))

    -   Rename `<Popover.Root>` to `<Popover.Context>`
- use Popover API, allowing `<Popover>` to be used without
`Popover.Context`
    -   Remove `portal` prop

- Select: Rename from `NativeSelect`
([#2404](#2404))

- Table: Set sort button type to prevent form submit
([#2402](#2402))

- Heading: default level is now 2
([#2378](#2378))

- Select: ([#2415](#2415))

    -   Add Select.Option and Select.Optgroup compond components
    -   Remove `multiple` prop

- Accordion: Now uses details and summary HTML elements
([`5d1c5062b526e6829c322ce66c6df08568bb9f63`](5d1c506))

- Spinner: Style using data attributes
([#2390](#2390))

- Avatar: new component
([#2312](#2312))

- Tag: Make neutral default color in CSS
([#2397](#2397))

- Card: Use data attrs
([#2398](#2398))

- Combobox: fix virtual combobox having large gap between items
([#2376](#2376))

## @digdir/designsystemet@1.0.0-next.33



## @digdir/designsystemet-theme@1.0.0-next.33

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eirikbacker eirikbacker eirikbacker approved these changes

@mimarz mimarz mimarz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change default Heading level to 2 as this is most used
3 participants
@Barsnes @eirikbacker @mimarz