Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): only theme on stories #2539

Merged
merged 1 commit into from
Oct 1, 2024
Merged

fix(storybook): only theme on stories #2539

merged 1 commit into from
Oct 1, 2024

Conversation

Barsnes
Copy link
Member

@Barsnes Barsnes commented Sep 30, 2024

Fixes white text and other color errors when changing to dark theme.
Updated to target only stories

Old:
image

Copy link

changeset-bot bot commented Sep 30, 2024

⚠️ No Changeset found

Latest commit: e2b81dc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Barsnes Barsnes marked this pull request as ready for review September 30, 2024 13:49
Copy link
Contributor

github-actions bot commented Sep 30, 2024

Preview deployments for this pull request:

Storybook - 30. Sep 2024 - 15:51

Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 59.81% 3856 / 6447
🔵 Statements 59.81% 3856 / 6447
🔵 Functions 86.31% 164 / 190
🔵 Branches 75.17% 533 / 709
File CoverageNo changed files found.
Generated in workflow #126

@Barsnes Barsnes merged commit a3164e0 into next Oct 1, 2024
7 checks passed
@Barsnes Barsnes deleted the storybook/colors branch October 1, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants