Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: focus changing color when changing mode #2557

Merged
merged 1 commit into from
Oct 2, 2024
Merged

fix: focus changing color when changing mode #2557

merged 1 commit into from
Oct 2, 2024

Conversation

Barsnes
Copy link
Member

@Barsnes Barsnes commented Oct 2, 2024

Sicne we don't set the focus vars on data-ds-color-mode, the color of the focus border is never changed since it is only calculated on :root

@Barsnes Barsnes marked this pull request as ready for review October 2, 2024 11:32
Copy link

changeset-bot bot commented Oct 2, 2024

⚠️ No Changeset found

Latest commit: ceab488

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Preview deployments for this pull request:

Storybook - 2. Oct 2024 - 13:35

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 59.19% 3742 / 6322
🔵 Statements 59.19% 3742 / 6322
🔵 Functions 86.31% 164 / 190
🔵 Branches 75.54% 516 / 683
File CoverageNo changed files found.
Generated in workflow #168 for commit ceab488 by the Vitest Coverage Report Action

@Barsnes Barsnes merged commit 09e1444 into next Oct 2, 2024
7 checks passed
@Barsnes Barsnes deleted the focus/color branch October 2, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants