feat(ValidationMessage): icon when error #2596
Open
+22
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a08e083 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Preview deployments for this pull request: Storybook - |
Coverage Report
File CoverageNo changed files found. |
eirikbacker
reviewed
Oct 10, 2024
| margin-right: var(--dsc-validation-message-icon-gap); | ||
| vertical-align: top; | ||
| background-color: currentcolor; | ||
| mask: var(--dsc-validation-message-icon-url) center/contain no-repeat; |
There was a problem hiding this comment.
If there is multiple lines of error text, should the text wrap around the icon, or should we solve this in the same way as Alert with padding + position?
There was a problem hiding this comment.
@Viveca24 should probably answer this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this syncs code with figma