Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Skeleton): text firefox #2600

Open
wants to merge 4 commits into
base: next
Choose a base branch
from
Open

Conversation

Copy link

changeset-bot bot commented Oct 10, 2024

⚠️ No Changeset found

Latest commit: bd6ff95

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 10, 2024

Preview deployments for this pull request:

Storybook - 10. Oct 2024 - 14:15

Copy link
Contributor

github-actions bot commented Oct 10, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 59.34% 3734 / 6292
🔵 Statements 59.34% 3734 / 6292
🔵 Functions 87.23% 164 / 188
🔵 Branches 75.32% 516 / 685
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/react/src/components/loaders/Skeleton/Skeleton.tsx 100% 25% 100% 100%
Generated in workflow #286 for commit bd6ff95 by the Vitest Coverage Report Action

Copy link
Contributor

@unekinn unekinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Eg legg merke til at i mobil-visning av Text Example storyen er litt rar. Du kan enten fikse sånn at eksempelet gir meining på 320px, eller skru av mobil-snapshoten med

TextExample.parameters = {
  chromatic: { modes: { mobile: { disable: true } } }
}
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👀 Ready for review
Development

Successfully merging this pull request may close these issues.

3 participants