Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add REST endpoints for OCSP responses #62

Merged
merged 4 commits into from
Apr 10, 2024
Merged

Add REST endpoints for OCSP responses #62

merged 4 commits into from
Apr 10, 2024

Conversation

mans-andersson
Copy link
Contributor

Endpoints should be added to allow OCSP response validation through the REST API.

@mans-andersson
Copy link
Contributor Author

Hi @CBonnell ,
It is a useful thing to be able validate OCSP responses through the REST API, in the same way as it can be done with the lint_ocsp_response CLI tool.
I have implemented this in a fork of the project, but I believe it could be useful for others as well.
Of course I welcome feedback and suggestions for how to improve the quality of the implementation.

@CBonnell
Copy link
Collaborator

Thanks for this contribution, @mans-andersson! I was at a conference last week and am catching up on a few things, but I plan to review/approve your PR sometime later this week.

CBonnell
CBonnell reviewed Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@CBonnell CBonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delayed review; I was at a conference last week and returned to a few urgent todo items I had to clear before reviewing.

Overall, the PR is very clean and concise. I made a few small suggestions. Let me know your thoughts on whether you want to modify the OCSP response validator initialization logic or if you prefer that I do that.

VERSION.txt Outdated Show resolved Hide resolved
pkilint/rest/__init__.py Outdated Show resolved Hide resolved
pkilint/rest/__init__.py Outdated Show resolved Hide resolved
pkilint/rest/__init__.py Outdated Show resolved Hide resolved
@CBonnell
Copy link
Collaborator

Can you pull the latest from main into your repo to fix the integration test failure? There's an upstream dependency that's (incorrectly) causing a test case failure. I just pushed a fix to main to resolve.

@mans-andersson mans-andersson force-pushed the feature-Add-OCSP-REST-endpoints branch from 4b41926 to 2806d06 Compare April 5, 2024 07:55
@mans-andersson
Add OCSP response check REST endpoints
84c347c 
Add two endpoints, one GET to retrieve the set of validations performed
on OCSP responses.
And one PUT endpoint to perform validations on OCSP responses.
@mans-andersson
Update OCSP endpoint routes
ca04cbc
@mans-andersson mans-andersson force-pushed the feature-Add-OCSP-REST-endpoints branch from 12a7c85 to 4dc8172 Compare April 5, 2024 09:07
@mans-andersson mans-andersson force-pushed the feature-Add-OCSP-REST-endpoints branch from 4dc8172 to 25ff34c Compare April 5, 2024 09:13
@CBonnell CBonnell self-requested a review April 10, 2024 21:20
CBonnell
CBonnell approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@CBonnell CBonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @mans-andersson! LGTM.

@CBonnell CBonnell merged commit 15ca8d8 into digicert:main Apr 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CBonnell CBonnell CBonnell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mans-andersson @CBonnell