Fix concurrent DAML compilations on Windows #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neil-da
approved these changes
Apr 24, 2019
cocreature
force-pushed
the
tmp-package-db
branch
from
34371af
to
07f9160
Compare
|
Good point, I’ve changed it to reuse the same directory name. |
neil-da
approved these changes
Apr 24, 2019
neil-da
reviewed
Apr 24, 2019
| tar xf {db_tar} -C tmp_db --strip-components 1 | ||
| mkdir -p tmp_db/{daml_lf_version} | ||
| PACKAGEDB="package_db_for_{name}" | ||
| # Since we don’t have sandboxing on Windows, that directory might |
There was a problem hiding this comment.
Suggested change
| # Since we don’t have sandboxing on Windows, that directory might | |
| # Since we don't have sandboxing on Windows, that directory might |
Smart quotes seem like a terrible idea here
cocreature
force-pushed
the
tmp-package-db
branch
from
991fd2b
to
b3e7ac0
Compare
garyverhaegen-da
force-pushed
the
tmp-package-db
branch
from
b3e7ac0
to
2cb6a67
Compare
Since Windows builds aren’t sandboxed properly (see bazelbuild/bazel#5136), concurrent compilations interact with the same tmp_db directory which leads to flaky build failures.
garyverhaegen-da
force-pushed
the
tmp-package-db
branch
from
2cb6a67
to
291296d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Windows builds aren’t sandboxed properly (see
bazelbuild/bazel#5136), concurrent
compilations interact with the same tmp_db directory which leads to
flaky build failures.
Pull Request Checklist
NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.