ci: use flake8-bugbear for linting (python-poetry#198)

.pre-commit-config.yaml

@@ -9,6 +9,8 @@ repos:
     rev: 3.9.2
     hooks:
       - id: flake8
+        additional_dependencies:
+          - flake8-bugbear
         exclude: |
           (?x)(
               ^poetry/core/utils/_typing.py$

poetry/core/masonry/builders/sdist.py

@@ -271,7 +271,7 @@ def find_nearest_pkg(rel_path: str) -> Tuple[str, str]:
             # Relative to the top-level package
             return pkg_name, Path(rel_path).as_posix()
 
-        for path, dirnames, filenames in os.walk(str(base), topdown=True):
+        for path, _dirnames, filenames in os.walk(str(base), topdown=True):
             if os.path.basename(path) == "__pycache__":
                 continue
 

poetry/core/utils/helpers.py

@@ -96,7 +96,7 @@ def safe_rmtree(path: Union[str, Path]) -> None:
 
 
 def merge_dicts(d1: dict, d2: dict) -> None:
-    for k, v in d2.items():
+    for k in d2.keys():
         if k in d1 and isinstance(d1[k], dict) and isinstance(d2[k], Mapping):
             merge_dicts(d1[k], d2[k])
         else:

tests/conftest.py

@@ -24,7 +24,7 @@ def pytest_configure(config):
     config.addinivalue_line("markers", "integration: mark integration tests")
 
     if not config.option.integration:
-        setattr(config.option, "markexpr", "not integration")
+        config.option.markexpr = "not integration"
 
 
 def get_project_from_dir(base_directory):  # type: (Path) -> Callable[[str], Path]