Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix picture serve multi images issue #108

Closed
wants to merge 1 commit into from
Closed

fix picture serve multi images issue #108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix picture serve multi images issue
  • Loading branch information
@idoshamun
idoshamun committed Sep 5, 2016
commit 22e289ad6125e15f005adb0d69cc6d6d21cdcd65
29 changes: 17 additions & 12 deletions blazy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,6 @@
var isImage = equal(ele, 'img');
// Image or background image
if (isImage || ele.src === undefined) {
var img = new Image();
// using EventListener instead of onerror and onload
// due to bug introduced in chrome v50
// (https://productforums.google.com/forum/#!topic/chrome/p51Lk7vnP2o)
Expand All @@ -194,13 +193,6 @@
if (isImage) {
setSrc(ele, src); //src
handleSource(ele, _attrSrcset, options.srcset); //srcset
//picture element
var parent = ele.parentNode;
if (parent && equal(parent, 'picture')) {
each(parent.getElementsByTagName('source'), function(source) {
handleSource(source, _attrSrcset, options.srcset);
});
}
// or background-image
} else {
ele.style.backgroundImage = 'url("' + src + '")';
Expand All @@ -209,9 +201,22 @@
unbindEvent(img, 'load', onLoadHandler);
unbindEvent(img, 'error', onErrorHandler);
};
bindEvent(img, 'error', onErrorHandler);
bindEvent(img, 'load', onLoadHandler);
setSrc(img, src); //preload

//picture element
var parent = ele.parentNode;
if (parent && equal(parent, 'picture')) {
setSrc(ele, src); //src
handleSource(ele, _attrSrcset, options.srcset); //srcset
each(parent.getElementsByTagName('source'), function(source) {
handleSource(source, _attrSrcset, options.srcset);
});
}
else {
var img = new Image();
bindEvent(img, 'error', onErrorHandler);
bindEvent(img, 'load', onLoadHandler);
setSrc(img, src); //preload
}
} else { // An item with src like iframe, unity, simpelvideo etc
setSrc(ele, src);
itemLoaded(ele, options);
Expand Down Expand Up @@ -314,4 +319,4 @@
fn.apply(scope, arguments);
};
}
});
});