Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds approx guild count and get self application endpoint #5971

Merged
merged 7 commits into from
Jul 13, 2023
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion docs/resources/Application.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,13 @@
| summary *(deprecated)* | string | **deprecated and will be removed in v11.** An empty string. |
| verify_key | string | the hex encoded key for verification in interactions and the GameSDK's [GetTicket](#DOCS_GAME_SDK_APPLICATIONS/getticket) |
| team | ?[team](#DOCS_TOPICS_TEAMS/data-models-team-object) object | if the application belongs to a team, this will be a list of the members of that team |
| guild_id? | snowflake | if this application is a game sold on Discord, this field will be the guild to which it has been linked |
| guild_id? | snowflake | guild associated with the bot. For example a developer support server. |
Copy link
Contributor

@splatterxl splatterxl Mar 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| guild_id? | snowflake | guild associated with the bot. For example a developer support server. |
| guild_id? | snowflake | guild associated with the bot, e.g. a developer support server |

Jupith marked this conversation as resolved.
Show resolved Hide resolved
| guild? | partial [guild](#DOCS_RESOURCES_GUILD/guild-object) object | a partial object of the associated guild |
| primary_sku_id? | snowflake | if this application is a game sold on Discord, this field will be the id of the "Game SKU" that is created, if exists |
| slug? | string | if this application is a game sold on Discord, this field will be the URL slug that links to the store page |
| cover_image? | string | the application's default rich presence invite [cover image hash](#DOCS_REFERENCE/image-formatting) |
| flags? | integer | the application's public [flags](#DOCS_RESOURCES_APPLICATION/application-object-application-flags) |
| approximate_guild_count? | integer | an approximate count of the bots guild membership. |
Copy link
Contributor

@splatterxl splatterxl Mar 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| approximate_guild_count? | integer | an approximate count of the bots guild membership. |
| approximate_guild_count? | integer | an approximate count of the guilds the bot was added to |

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"an application" doesn't really match the rest, it should be "the application", like how the current docs say "the bots"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either way it's not a count of app membership, just bot.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe something like an approximate count of the guilds the bot was added to

Jupith marked this conversation as resolved.
Show resolved Hide resolved
| tags? | array of strings | up to 5 tags describing the content and functionality of the application |
| install_params? | [install params](#DOCS_RESOURCES_APPLICATION/install-params-object) object | settings for the application's default in-app authorization link, if enabled |
| custom_install_url? | string | the application's default custom authorization link, if enabled |
Expand Down Expand Up @@ -94,3 +96,7 @@
| ----------- | ---------------- | ---------------------------------------------------------------------------------------------------------- |
| scopes | array of strings | the [scopes](#DOCS_TOPICS_OAUTH2/shared-resources-oauth2-scopes) to add the application to the server with |
| permissions | string | the [permissions](#DOCS_TOPICS_PERMISSIONS) to request for the bot role |

## Get Current Bot Application Information % GET /applications/@me
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there, what is going to happen to the /oauth2/applications/@me route? Is it still going to be supported, or is it going to be deprecated and eventually replaced with this route?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing changes here. It was just not documented.

Jupith marked this conversation as resolved.
Show resolved Hide resolved

Returns the bot's [application](#DOCS_RESOURCES_APPLICATION/application-object) object.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would add a note that the info returned from this endpoint is partial/different from the oauth2 route

Jupith marked this conversation as resolved.
Show resolved Hide resolved