Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Bump dependencies #10322

Merged
merged 2 commits into from
Jun 5, 2024
Merged

build: Bump dependencies #10322

merged 2 commits into from
Jun 5, 2024

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Jun 3, 2024

No description provided.

@Jiralite Jiralite requested review from a team and iCrawl as code owners June 3, 2024 13:35
Copy link

vercel bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Jun 3, 2024 1:59pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jun 3, 2024 1:59pm

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.24%. Comparing base (94cc02a) to head (4f16b06).

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #10322       +/-   ##
===========================================
+ Coverage   19.13%   49.24%   +30.10%     
===========================================
  Files          31      248      +217     
  Lines        6250    21240    +14990     
  Branches      111     1172     +1061     
===========================================
+ Hits         1196    10459     +9263     
- Misses       5054    10733     +5679     
- Partials        0       48       +48     
Flag Coverage Δ
brokers 49.24% <ø> (+30.10%) ⬆️
builders 49.24% <ø> (+30.10%) ⬆️
collection 49.24% <ø> (+30.10%) ⬆️
discord.js 49.24% <ø> (+30.10%) ⬆️
formatters 49.24% <ø> (+30.10%) ⬆️
guide 49.24% <ø> (+30.10%) ⬆️
next 49.24% <ø> (+30.10%) ⬆️
proxy 49.24% <ø> (+30.10%) ⬆️
rest 49.24% <ø> (+30.10%) ⬆️
util 49.24% <ø> (+30.10%) ⬆️
utilities 49.24% <ø> (+30.10%) ⬆️
voice 49.24% <ø> (+30.10%) ⬆️
website 49.24% <ø> (+30.10%) ⬆️
ws 49.24% <ø> (+30.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodiakhq kodiakhq bot merged commit 346d1be into main Jun 5, 2024
24 checks passed
@kodiakhq kodiakhq bot deleted the build/bump-dependencies branch June 5, 2024 09:42
@jacoobes
Copy link

jacoobes commented Jun 30, 2024

It still seems the issue of websocket vulnerabilities is present. Could there be a re bump to @discordjs/ws?
its stuck on 8.17.0 after installation, vulnerabilty is resolved in 8.17.1. @Jiralite
on npm and yarn, running npm i or yarn respectively resolves ^8.16.0 to 8.17.0.
Best minimal example is
git clone https://github.com/sern-handler/handler.git, git checkout feat/v4, run yarn. I am on yarn 3.5.1

@Jiralite
Copy link
Member Author

This pull request has not landed in a release yet. You can work around this by using resolutions.

Our current plan is to release packages once we have tried-and-ready support for user-installable applications (#10227 & #10348) which should not be far off.

@jacoobes
Copy link

This pull request has not landed in a release yet. You can work around this by using resolutions.

Our current plan is to release packages once we have tried-and-ready support for user-installable applications (#10227 & #10348) which should not be far off.

thanks for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants