-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Split message send/edit types/documentation #8590
refactor: Split message send/edit types/documentation #8590
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Codecov Report
@@ Coverage Diff @@
## main #8590 +/- ##
==========================================
- Coverage 86.47% 86.47% -0.01%
==========================================
Files 87 87
Lines 8675 8679 +4
Branches 1110 1110
==========================================
+ Hits 7502 7505 +3
- Misses 1131 1132 +1
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Please describe the changes this PR makes and why it should be merged:
Some general refactoring around sending and editing messages. For example,
attachments
showed up when sending a message when it should not - it should appear when editing. This also resolves #8587.