-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): implement some ws send events #8941
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The readme example needs to be updated to use the new Client class
d76c32e
to
00476e7
Compare
2d48e80
to
5b3a334
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, I was thinking that maybe we should probably support a version of requestGuildMembers
which returns an async iterable, so we can do operations on members while they come thru. Obviously, requestGuildMembers
would consume this async iterator and flatten the chunks.
15eea3c
to
7d608bb
Compare
Codecov Report
@@ Coverage Diff @@
## main #8941 +/- ##
==========================================
+ Coverage 84.35% 84.48% +0.12%
==========================================
Files 98 99 +1
Lines 9180 9268 +88
Branches 1096 1100 +4
==========================================
+ Hits 7744 7830 +86
- Misses 1394 1396 +2
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I'd open an issue for this so we dont forget @kyranet |
Please describe the changes this PR makes and why it should be merged:
This implements guild member requests, voice state updating and presence updating for /core.
This PR is breaking as it converts
createClient
to a class.Status and versioning classification: