-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(handlers): create burst handler for interaction callbacks #8996
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
9f075be
to
2410191
Compare
Codecov Report
@@ Coverage Diff @@
## main #8996 +/- ##
==========================================
+ Coverage 79.43% 83.76% +4.33%
==========================================
Files 121 102 -19
Lines 10070 9812 -258
Branches 1124 1131 +7
==========================================
+ Hits 7999 8219 +220
+ Misses 2031 1554 -477
+ Partials 40 39 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 23 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Co-Authored-By: Almeida <almeidx@pm.me>
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
8e2e13f
to
7a2da4c
Compare
@kyranet is attempting to deploy a commit to the discordjs Team on Vercel. A member of the Team first needs to authorize it. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://discord-js-git-fork-ckohen-fix-interactions-ratelimit-discordjs.vercel.app/ |
Please describe the changes this PR makes and why it should be merged:
Interaction callbacks currently create a queue per callback, this is unnecessary and consumes excess memory for no reason.
The burst handler ignores all ratelimits (except for hitting 429s) because that's what callbacks do.
What do we think of how the route is handled with this? As it currently is this resolves #9019
Also solves the testing issue on Node 18+
Status and versioning classification: