Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types(ThreadEditOptions): Add appliedTags #9022

Merged
merged 1 commit into from
Jan 10, 2023
Merged

types(ThreadEditOptions): Add appliedTags #9022

merged 1 commit into from
Jan 10, 2023

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Jan 7, 2023

Please describe the changes this PR makes and why it should be merged:
This was simply missing. Functionality for this already exists.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Jan 7, 2023

@Jiralite is attempting to deploy a commit to the discordjs Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Jan 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
discord-js ❌ Failed (Inspect) Jan 7, 2023 at 9:32AM (UTC)

@Jiralite Jiralite added this to the discord.js v13.13 milestone Jan 7, 2023
SpaceEEC
SpaceEEC approved these changes Jan 7, 2023
View reviewed changes
Copy link
Member

@SpaceEEC SpaceEEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprise features

@iCrawl iCrawl merged commit 6854df4 into discordjs:v13 Jan 10, 2023
@Jiralite Jiralite deleted the types/thread-edit-properties branch January 10, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl

@vladfrangu vladfrangu Awaiting requested review from vladfrangu

Assignees
No one assigned
Labels
packages:discord.js semver:patch threads typings
Projects
discord.js
Archived in project
Milestone
discord.js 13.13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Jiralite @kyranet @SpaceEEC @iCrawl