-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(website): add support for source file links #9048
Merged
iCrawl
merged 7 commits into
discordjs:main
from
suneettipirneni:website/feat/source-links
Jan 12, 2023
Merged
feat(website): add support for source file links #9048
iCrawl
merged 7 commits into
discordjs:main
from
suneettipirneni:website/feat/source-links
Jan 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
January 12, 2023 03:26
Note, you won't see the links on the preview since the |
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 This PR introduced no changes to the javascript bundle 🙌 |
cyan-2048
pushed a commit
to cyan-2048/discord.js
that referenced
this pull request
May 8, 2024
Co-authored-by: Noel <buechler.noel@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
In addition to providing links for each item page, there have been a few changes to CI. Instead of generating documentation based on output provided by tsup, we instead use the build output of only declaration files and declaration maps. The reasoning for this is tsup doesn't support declaration maps, using
tsc
to add declarations after tsup has compiled overwrites the rolled upindex.d.ts
files and maps totsc
output nottsup
output. This build output goes intodist-docs
and api-extractor reads the model from there.