Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): add support for source file links #9048

Merged
merged 7 commits into from
Jan 12, 2023

Conversation

suneettipirneni
Copy link
Member

@suneettipirneni suneettipirneni commented Jan 12, 2023

Please describe the changes this PR makes and why it should be merged:

In addition to providing links for each item page, there have been a few changes to CI. Instead of generating documentation based on output provided by tsup, we instead use the build output of only declaration files and declaration maps. The reasoning for this is tsup doesn't support declaration maps, using tsc to add declarations after tsup has compiled overwrites the rolled up index.d.ts files and maps to tsc output not tsup output. This build output goes into dist-docs and api-extractor reads the model from there.

@vercel
Copy link

vercel bot commented Jan 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 12, 2023 at 0:29AM (UTC)
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 12, 2023 at 0:29AM (UTC)

@suneettipirneni
Copy link
Member Author

Note, you won't see the links on the preview since the api.json models are older from the api.

@github-actions
Copy link

github-actions bot commented Jan 12, 2023

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

This PR introduced no changes to the javascript bundle 🙌

@iCrawl iCrawl merged commit f6506e9 into discordjs:main Jan 12, 2023
cyan-2048 pushed a commit to cyan-2048/discord.js that referenced this pull request May 8, 2024
Co-authored-by: Noel <buechler.noel@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants