Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix version export #9049

Merged
merged 7 commits into from
Jan 19, 2023
Merged

Conversation

Syjalo
Copy link
Contributor

@Syjalo Syjalo commented Jan 12, 2023

Please describe the changes this PR makes and why it should be merged:
This PR fixes version export description

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Jan 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 19, 2023 at 3:51PM (UTC)
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 19, 2023 at 3:51PM (UTC)

@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #9049 (297e3af) into main (56ef3ad) will increase coverage by 0.66%.
The diff coverage is 100.00%.

❗ Current head 297e3af differs from pull request most recent head b23de26. Consider uploading reports for the commit b23de26 to get more accurate results

@@            Coverage Diff             @@
##             main    #9049      +/-   ##
==========================================
+ Coverage   84.11%   84.78%   +0.66%     
==========================================
  Files         108       97      -11     
  Lines        9488     8904     -584     
  Branches     1113     1083      -30     
==========================================
- Hits         7981     7549     -432     
+ Misses       1466     1314     -152     
  Partials       41       41              
Flag Coverage Δ
brokers ?
builders 98.25% <ø> (ø)
collection 100.00% <ø> (ø)
next 0.00% <ø> (ø)
proxy 79.56% <ø> (ø)
rest 92.07% <100.00%> (+<0.01%) ⬆️
util ?
utilities ?
voice 63.77% <100.00%> (ø)
ws 59.49% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/rest/src/lib/utils/constants.ts 98.24% <100.00%> (+0.03%) ⬆️
packages/voice/src/index.ts 100.00% <100.00%> (ø)
packages/ws/src/utils/constants.ts 85.71% <100.00%> (ø)
packages/util/src/functions/calculateShardId.ts
packages/actions/src/formatTag/formatTag.ts
packages/util/src/types.ts
packages/util/src/functions/lazy.ts
packages/util/src/functions/range.ts
packages/util/src/Equatable.ts
packages/brokers/src/brokers/Broker.ts
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

This reverts commit ba983f0.
I hate my local repo. It can't install deps with `--immutable` and a have weird error on `yarn test`, but the CI passes
@vercel
Copy link

vercel bot commented Jan 19, 2023

@Syjalo is attempting to deploy a commit to the discordjs Team on Vercel.

A member of the Team first needs to authorize it.

@kodiakhq kodiakhq bot merged commit 8b70f49 into discordjs:main Jan 19, 2023
@Syjalo Syjalo deleted the docs-fix/fix-version-export branch January 19, 2023 15:57
cyan-2048 pushed a commit to cyan-2048/discord.js that referenced this pull request May 8, 2024
* docs: fix version export

* types: assert `[VI]{{inject}}[/VI]` as string

* types: typo

* Revert "types: typo"

This reverts commit ba983f0.

* types: typo

I hate my local repo. It can't install deps with `--immutable` and a have weird error on `yarn test`, but the CI passes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants