-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add GuildBasedTextChannelTypes #9234
feat: add GuildBasedTextChannelTypes #9234
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Also as a sidenote I can't get CI to pass locally so I committed this with --no-verify |
4529a10
to
8526d2e
Compare
Which of course explains the CI fail but it should pass now |
This needs a rebase (stage channels were added here). |
Thanks for the heads up! Rebased it now |
8526d2e
to
cdcfc73
Compare
Rebased twice cuz I forgot the docs |
cdcfc73
to
62e03f2
Compare
Co-authored-by: Jaw0r3k <jaworekwiadomosci@gmail.com>
Are you referring to the channel option types? 👁️ |
To be crystal clear, it is caused by #8990 due to now-narrow typings. |
That is indeed what I meant. I also recall proposing this change a while ago but it was rejected since Discord allows any channel types (which it still does to my knowledge) so I find it a bit odd that it was done now but yeah that was the motivation |
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
So the removing review bug is still a thing, nice. Can someone add those back? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub you drunk drunk
Please describe the changes this PR makes and why it should be merged:
Since 14.8.0, Constants.TextBasedChannelTypes is no longer assignable to ApplicationCommand#channelTypes due to the DM type not being accepted, so this fixes that
Status and versioning classification: