-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: call GuildBanManager#create()
directly
#9263
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
3d4598a
to
9e1f9b6
Compare
@TetieWasTaken is attempting to deploy a commit to the discordjs Team on Vercel. A member of the Team first needs to authorize it. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://discord-js-git-fork-tetiewastaken-direct-ban-discordjs.vercel.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷
Please describe the changes this PR makes and why it should be merged:
Instead of calling
GuildBanManager#ban()
atGuildMember#ban()
, we callGuildBanManager#create()
directly. SinceGuildMemberManager#ban()
simply callsGuildBanManager#create()
aswell. Thus skipping a useless redirect.discord.js/packages/discord.js/src/structures/GuildMember.js
Lines 384 to 386 in 950fc47
discord.js/packages/discord.js/src/managers/GuildMemberManager.js
Lines 484 to 486 in 950fc47
discord.js/packages/discord.js/src/managers/GuildBanManager.js
Line 154 in 950fc47
Status and versioning classification: